[P1-L04] Update require messages

[chrismaree]

This PR updates require messages within the DVM. Specifically places that were missing require messages now include them and messages that are over 32 chars in length were decreased to optimize gas usage.

[chrismaree]

unrelated to changes but locking this prettier version because prettier 1.0.0-alpha.48 is now out which results in a bunch of linting changes to our code. If we enable higher versions we will need to lint all the contracts again.

[nicholaspai]

you're unlocking or locking? it looks like you're unlocking

[chrismaree]

To my understanding this pins us to use exactly this package version.

[nicholaspai]

Doesn't the "^" pin it?

[nicholaspai]

https://semver.npmjs.com/

I stand corrected. Based on this, the "^" does not pin it.

[mrice32]

Aren't there a few requires in Voting.sol that don't have messages?

[chrismaree]

Aren't there a few requires in Voting.sol that don't have messages?

The only ones that currently dont have are in modifiers. I can add messages to these but they are quite low level. For consistancy sake I'll add them

modifier onlyRegisteredContract() {
        if (migratedAddress != address(0)) {
            require(msg.sender == migratedAddress);
        } else {
            Registry registry = Registry(finder.getImplementationAddress(OracleInterfaces.Registry));
            require(registry.isContractRegistered(msg.sender));
        }
        _;
    }

    modifier onlyIfNotMigrated() {
        require(migratedAddress == address(0));
        _;
    }

[mrice32]

LGTM!