[P1-L04] Update require messages (#1259)

* Updated require messages

Signed-off-by: Christopher Maree <christopher.maree@gmail.com>

* Updated spacing

Signed-off-by: Christopher Maree <christopher.maree@gmail.com>

* Reverted lint change

Signed-off-by: Christopher Maree <christopher.maree@gmail.com>

* reverted nit

Signed-off-by: Christopher Maree <christopher.maree@gmail.com>

* nits

Signed-off-by: Christopher Maree <christopher.maree@gmail.com>

Author: chrismaree

core/contracts/oracle/implementation/Finder.sol

@@ -25,7 +25,7 @@ contract Finder is FinderInterface, Ownable {
     // TODO(#969) Remove once prettier-plugin-solidity can handle the "override" keyword
     // prettier-ignore
     function changeImplementationAddress(bytes32 interfaceName, address implementationAddress) external override onlyOwner {
-        require(implementationAddress.isContract(),"Can only change implementation to a contract");
+        require(implementationAddress.isContract(),"New address must be a contract");
         interfacesImplemented[interfaceName] = implementationAddress;
 
         emit InterfaceImplementationChanged(interfaceName, implementationAddress);
@@ -40,7 +40,7 @@ contract Finder is FinderInterface, Ownable {
     // prettier-ignore
     function getImplementationAddress(bytes32 interfaceName) external override view returns (address) {
         address implementationAddress = interfacesImplemented[interfaceName];
-        require(implementationAddress != address(0x0), "No implementation for interface found");
+        require(implementationAddress != address(0x0), "Implementation not found");
         return implementationAddress;
     }
 }

core/contracts/oracle/implementation/Governor.sol

@@ -97,10 +97,10 @@ contract Governor is MultiRole, Testable {
 
         // Initialize the transaction array.
         for (uint256 i = 0; i < transactions.length; i++) {
-            require(transactions[i].to != address(0), "The to address cannot be 0x0");
+            require(transactions[i].to != address(0), "The `to` address cannot be 0x0");
             // If the transaction has any data with it the recipient must be a contract, not an EOA.
             if (transactions[i].data.length > 0) {
-                require(transactions[i].to.isContract(), "Only propose transactions on a contract");
+                require(transactions[i].to.isContract(), "EOA can't accept tx with data");
             }
             proposal.transactions.push(transactions[i]);
         }
@@ -132,16 +132,16 @@ contract Governor is MultiRole, Testable {
 
         require(
             transactionIndex == 0 || proposal.transactions[transactionIndex.sub(1)].to == address(0),
-            "Previous transaction has not been executed"
+            "Previous tx not yet executed"
         );
-        require(transaction.to != address(0), "Transaction has already been executed");
-        require(price != 0, "Cannot execute, proposal was voted down");
-        require(msg.value == transaction.value, "Must send the exact amount of ETH to execute transaction");
+        require(transaction.to != address(0), "Tx already executed");
+        require(price != 0, "Proposal was rejected");
+        require(msg.value == transaction.value, "Must send exact amount of ETH");
 
         // Delete the transaction before execution to avoid any potential re-entrancy issues.
         delete proposal.transactions[transactionIndex];
 
-        require(_executeCall(transaction.to, transaction.value, transaction.data), "Transaction execution failed");
+        require(_executeCall(transaction.to, transaction.value, transaction.data), "Tx execution failed");
 
         emit ProposalExecuted(id, transactionIndex);
     }

core/contracts/oracle/implementation/Registry.sol

@@ -109,7 +109,6 @@ contract Registry is RegistryInterface, MultiRole {
     // prettier-ignore
     function addPartyToContract(address party) external override {
         address contractAddress = msg.sender;
-
         require(contractMap[contractAddress].valid == Validity.Valid, "Can only add to valid contract");
 
         _addPartyToContract(party, contractAddress);
@@ -126,10 +125,10 @@ contract Registry is RegistryInterface, MultiRole {
         address contractAddress = msg.sender;
         Party storage party = partyMap[partyAddress];
         uint256 numberOfContracts = party.contracts.length;
-
-        require(numberOfContracts != 0, "Can't remove if party has no contracts");
+        
+        require(numberOfContracts != 0, "Party has no contracts");
         require(contractMap[contractAddress].valid == Validity.Valid, "Remove only from valid contract");
-        require(isPartyMemberOfContract(partyAddress, contractAddress), "Can only remove an existing party");
+        require(isPartyMemberOfContract(partyAddress, contractAddress), "Can only remove existing party");
 
         // Index of the current location of the contract to remove.
         uint256 deleteIndex = party.contractIndex[contractAddress];

core/contracts/oracle/implementation/Store.sol

@@ -59,7 +59,7 @@ contract Store is StoreInterface, Withdrawable, Testable {
     // TODO(#969) Remove once prettier-plugin-solidity can handle the "override" keyword
     // prettier-ignore
     function payOracleFees() external override payable {
-        require(msg.value > 0);
+        require(msg.value > 0, "Value sent can't be zero");
     }
 
     /**
@@ -72,7 +72,7 @@ contract Store is StoreInterface, Withdrawable, Testable {
     // prettier-ignore
     function payOracleFeesErc20(address erc20Address, FixedPoint.Unsigned calldata amount) external override {
         IERC20 erc20 = IERC20(erc20Address);
-        require(amount.isGreaterThan(0));
+        require(amount.isGreaterThan(0), "Amount sent can't be zero");
         erc20.safeTransferFrom(msg.sender, address(this), amount.rawValue);
     }
 
@@ -140,7 +140,7 @@ contract Store is StoreInterface, Withdrawable, Testable {
         onlyRoleHolder(uint(Roles.Owner))
     {
         // Oracle fees at or over 100% don't make sense.
-        require(newFixedOracleFeePerSecondPerPfc.isLessThan(1));
+        require(newFixedOracleFeePerSecondPerPfc.isLessThan(1), "Fee must be < 100% per second.");
         fixedOracleFeePerSecondPerPfc = newFixedOracleFeePerSecondPerPfc;
         emit NewFixedOracleFeePerSecondPerPfc(newFixedOracleFeePerSecondPerPfc);
     }

core/contracts/oracle/implementation/TokenMigrator.sol

@@ -36,7 +36,7 @@ contract TokenMigrator {
     constructor(FixedPoint.Unsigned memory _rate, address _oldToken, address _newToken) public {
         // Prevents division by 0 in migrateTokens().
         // Also it doesn’t make sense to have “0 old tokens equate to 1 new token”.
-        require(_rate.isGreaterThan(0));
+        require(_rate.isGreaterThan(0), "Rate can't be 0");
         rate = _rate;
         newToken = ExpandedIERC20(_newToken);
         oldToken = VotingToken(_oldToken);

core/contracts/oracle/implementation/Voting.sol

@@ -195,16 +195,16 @@ contract Voting is Testable, Ownable, OracleInterface, VotingInterface {
 
     modifier onlyRegisteredContract() {
         if (migratedAddress != address(0)) {
-            require(msg.sender == migratedAddress);
+            require(msg.sender == migratedAddress, "Caller must be migrated address");
         } else {
             Registry registry = Registry(finder.getImplementationAddress(OracleInterfaces.Registry));
-            require(registry.isContractRegistered(msg.sender));
+            require(registry.isContractRegistered(msg.sender), "Called must be registered");
         }
         _;
     }
 
     modifier onlyIfNotMigrated() {
-        require(migratedAddress == address(0));
+        require(migratedAddress == address(0), "Only call this if not migrated");
         _;
     }
 
@@ -348,7 +348,7 @@ contract Voting is Testable, Ownable, OracleInterface, VotingInterface {
     // prettier-ignore
     function snapshotCurrentRound() external override onlyIfNotMigrated() {
         uint blockTime = getCurrentTime();
-        require(voteTiming.computeCurrentPhase(blockTime) == Phase.Reveal, "Can only snapshot in reveal phase");
+        require(voteTiming.computeCurrentPhase(blockTime) == Phase.Reveal, "Only snapshot in reveal phase");
 
         uint roundId = voteTiming.computeCurrentRoundId(blockTime);
         _freezeRoundVariables(roundId);

package.json

@@ -22,7 +22,7 @@
     "husky": "^4.2.3",
     "lint-staged": "^10.1.3",
     "prettier": "1.19.1",
-    "prettier-plugin-solidity": "^1.0.0-alpha.46",
+    "prettier-plugin-solidity": "1.0.0-alpha.46",
     "pretty-quick": "^2.0.1",
     "solidity-coverage": "^0.7.2",
     "truffle-deploy-registry": "^0.5.1"