feat: include fee transfer logs for reverting transactions#729
Merged
Conversation
joshieDo
approved these changes
Nov 5, 2025
unbalancedparentheses
pushed a commit
to unbalancedparentheses/tempo
that referenced
this pull request
Feb 23, 2026
) This PR ensures that logs for fee token transfer are always included into the transaction receipt, even if transaction reverted. This work arounds the fact that revm `ExecutionResult` does not contain `logs` for `Revert`/`Halt` variants. We should remove this once it's supported This also contains a fix for a bug when no `Transfer` log is emitted for cases when there's no fee token refund happening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that logs for fee token transfer are always included into the transaction receipt, even if transaction reverted.
This work arounds the fact that revm
ExecutionResultdoes not containlogsforRevert/Haltvariants. We should remove this once it's supportedThis also contains a fix for a bug when no
Transferlog is emitted for cases when there's no fee token refund happening