feat(consensus): switch from discovery p2p to lookup p2p#636
Merged
SuperFluffy merged 2 commits intomainfrom Nov 3, 2025
Merged
feat(consensus): switch from discovery p2p to lookup p2p#636SuperFluffy merged 2 commits intomainfrom
SuperFluffy merged 2 commits intomainfrom
Conversation
SuperFluffy
commented
Nov 2, 2025
| oracle | ||
| .update(0, config.peers.keys().cloned().collect()) | ||
| .await; | ||
| let all_resolved_peers = resolve_all_peers(&config.peers) |
Contributor
Author
There was a problem hiding this comment.
We don't check if our pubkey is among the peers. It's not necessary for lookup p2p.
klkvr
approved these changes
Nov 2, 2025
unbalancedparentheses
pushed a commit
to unbalancedparentheses/tempo
that referenced
this pull request
Feb 23, 2026
This patch changes the consensus p2p network from discovery to lookup. Where before, one or more known bootstrapper nodes were provided, now all nodes have to be known at startup in order to communicate with each other. This change is a requirement for dynamic validator sets using on-chain lookup and is done in this patch to de-risk tempoxyz#585. As part of this patch the following changes were done to the consensus config file: 1. the `bootstrappers` entry was removed. 2. `listen_port` was removed 3. `listen_addr` was added 4. `dialable_addr` was added Our commonware x reth e2e tests use a simulated network, and so we are not testing this part of the flow. However, I spun up a local network of nodes using this and the nodes were able to connect and produce blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes the consensus p2p network from discovery to lookup. Where before, one or more known bootstrapper nodes were provided, now all nodes have to be known at startup in order to communicate with each other.
This change is a requirement for dynamic validator sets using on-chain lookup and is done in this patch to de-risk #585.
As part of this patch the following changes were done to the consensus config file:
bootstrappersentry was removed.listen_portwas removedlisten_addrwas addeddialable_addrwas addedOur commonware x reth e2e tests use a simulated network, and so we are not testing this part of the flow.
However, I spun up a local network of nodes using this and the nodes were able to connect and produce blocks.