feat: Add dex_getOrders endpoint and schema#546
Conversation
| } | ||
|
|
||
| #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)] | ||
| pub struct Order { |
There was a problem hiding this comment.
Are we able to use the Order struct from the precompile crate directly?
There was a problem hiding this comment.
The RPC represents it differently and has features that wouldn't make sense for the precompile type (for example, why would the precompile representation be serializable to JSON?).
There was a problem hiding this comment.
we could potentially unify those if we add serde support for this order type
cf60669 to
27ec6b0
Compare
|
Thanks for your review @0xKitsune, I applied your suggestions. For all the numeric types discrepancies, the spec called those are either a |
27ec6b0 to
0892ece
Compare
mattsse
left a comment
There was a problem hiding this comment.
we also want some additional serde roundtrip test to ensure Optional fields behave as expected
| } | ||
|
|
||
| #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)] | ||
| pub struct Order { |
There was a problem hiding this comment.
we could potentially unify those if we add serde support for this order type
0892ece to
bfed126
Compare
mattsse
left a comment
There was a problem hiding this comment.
lgtm
naming suggestion
we can take a look at whether we can unify the order types separately
bfed126 to
a82d5f1
Compare
Part of tempoxyz#536 Adds a trait, parameters and response type.
Part of #536
Adds a trait, parameters and response type.