feat: add error types for fee lane decoding in EVM operations#360
Merged
feat: add error types for fee lane decoding in EVM operations#360
Conversation
7ea16c4 to
914ce1d
Compare
mattsse
reviewed
Sep 29, 2025
Comment on lines
+10
to
+14
| FeeLaneDecoding(String), | ||
|
|
||
| /// Invalid EVM configuration. | ||
| #[error("invalid EVM configuration: {0}")] | ||
| InvalidEvmConfig(String), |
Contributor
There was a problem hiding this comment.
should we just keep box dyn error here @klkvr ?
Member
There was a problem hiding this comment.
makes sense, though I think those would never be constructed
SuperFluffy
reviewed
Sep 29, 2025
klkvr
approved these changes
Sep 29, 2025
Comment on lines
+116
to
+118
| self.inner.evm_env(header).map_err(|_| { | ||
| TempoEvmError::InvalidEvmConfig("failed to create EVM environment".to_string()) | ||
| }) |
Member
There was a problem hiding this comment.
those should be unreachable right? because inner's error is Infallible
Contributor
There was a problem hiding this comment.
It might be nice to keep this, it seems like its technically possible that evm_env is updated to return an error without any breaking changes right? In this case we handle this error.
0xKitsune
reviewed
Oct 2, 2025
0xKitsune
approved these changes
Oct 2, 2025
Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io>
8455073 to
e5e4dfe
Compare
Co-authored-by: 0xKitsune <77890308+0xKitsune@users.noreply.github.com>
fgimenez
added a commit
that referenced
this pull request
Oct 3, 2025
Closes: #356 --------- Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io> Co-authored-by: 0xKitsune <77890308+0xKitsune@users.noreply.github.com>
legion2002
pushed a commit
that referenced
this pull request
Oct 9, 2025
Closes: #356 --------- Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io> Co-authored-by: 0xKitsune <77890308+0xKitsune@users.noreply.github.com>
unbalancedparentheses
pushed a commit
to unbalancedparentheses/tempo
that referenced
this pull request
Feb 23, 2026
…yz#360) Closes: tempoxyz#356 --------- Co-authored-by: Richard Janis Goldschmidt <github@aberrat.io> Co-authored-by: 0xKitsune <77890308+0xKitsune@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #356