Skip to content

chore: remove JournalStorageProvider#352

Merged
klkvr merged 1 commit intomainfrom
klkvr/rm-journal-storage-provider
Sep 29, 2025
Merged

chore: remove JournalStorageProvider#352
klkvr merged 1 commit intomainfrom
klkvr/rm-journal-storage-provider

Conversation

@klkvr
Copy link
Copy Markdown
Member

@klkvr klkvr commented Sep 26, 2025

We have a way to create EvmInternals from context so this can be removed

Copy link
Copy Markdown
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

Comment on lines -50 to -52
self.journal.load_account(address)?;
self.journal.touch_account(address);
self.journal.sstore(address, key, value)?;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this behaviour is perhaps different on EvmStorageProvider?

@mattsse mattsse self-requested a review September 26, 2025 15:42
@mattsse
Copy link
Copy Markdown
Contributor

mattsse commented Sep 26, 2025

we should def clean this up but these currently have different implementations

impl<'a> StorageProvider for EvmStorageProvider<'a> {
type Error = EvmInternalsError;
fn chain_id(&self) -> u64 {
self.chain_id
}
fn set_code(&mut self, address: Address, code: Bytecode) -> Result<(), Self::Error> {
self.ensure_loaded_account(address)?;
self.internals.set_code(address, code);
Ok(())
}
fn get_account_info(&mut self, address: Address) -> Result<AccountInfo, Self::Error> {
self.ensure_loaded_account(address)?;
let account = self.internals.load_account_code(address)?;
Ok(account.data.info.clone())
}
fn sstore(&mut self, address: Address, key: U256, value: U256) -> Result<(), Self::Error> {
self.ensure_loaded_account(address)?;
self.internals.sstore(address, key, value)?;
Ok(())
}

or maybe not, a bit hard to tell honestly

@klkvr klkvr force-pushed the klkvr/rm-journal-storage-provider branch from aac0fdb to e0449fa Compare September 29, 2025 09:54
@klkvr klkvr merged commit b36a4dd into main Sep 29, 2025
15 checks passed
@klkvr klkvr deleted the klkvr/rm-journal-storage-provider branch September 29, 2025 10:00
legion2002 pushed a commit that referenced this pull request Oct 9, 2025
We have a way to create `EvmInternals` from context so this can be
removed
unbalancedparentheses pushed a commit to unbalancedparentheses/tempo that referenced this pull request Feb 23, 2026
We have a way to create `EvmInternals` from context so this can be
removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants