Merged
Conversation
mattsse
reviewed
Sep 26, 2025
Comment on lines
-50
to
-52
| self.journal.load_account(address)?; | ||
| self.journal.touch_account(address); | ||
| self.journal.sstore(address, key, value)?; |
Contributor
There was a problem hiding this comment.
hmm, this behaviour is perhaps different on EvmStorageProvider?
Contributor
|
we should def clean this up but these currently have different implementations tempo/crates/precompiles/src/contracts/storage/evm.rs Lines 27 to 50 in 31479ce or maybe not, a bit hard to tell honestly |
aac0fdb to
e0449fa
Compare
legion2002
pushed a commit
that referenced
this pull request
Oct 9, 2025
We have a way to create `EvmInternals` from context so this can be removed
unbalancedparentheses
pushed a commit
to unbalancedparentheses/tempo
that referenced
this pull request
Feb 23, 2026
We have a way to create `EvmInternals` from context so this can be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a way to create
EvmInternalsfrom context so this can be removed