Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
f0c033e to
da6747c
Compare
da6747c to
4a607f1
Compare
SuperFluffy
approved these changes
Jan 2, 2026
Contributor
SuperFluffy
left a comment
There was a problem hiding this comment.
Looks fine to me. The test seems a bit overkill and I am on the fence about the metric, but other than that it's great!
|
|
||
| /// Whether the next DKG ceremony should be a full ceremony (new polynomial) | ||
| /// instead of a reshare. Set when `nextFullDkgCeremony == epoch`. | ||
| pub is_next_full_dkg: bool, |
Contributor
There was a problem hiding this comment.
Should this be an epoch number instead of a boolean?
| if onchain_outcome.output == state.output { | ||
| self.metrics.failures.inc(); | ||
| if state.is_full_dkg { | ||
| self.metrics.full_failures.inc(); |
Contributor
There was a problem hiding this comment.
Let's just have a single counter for full re-DKGs instead of 2 new metrics for failures and successes.
| async fn wait_for_outcome( | ||
| &self, | ||
| context: &Context, | ||
| validators: &[TestingNode<Context>], |
Contributor
There was a problem hiding this comment.
Maybe just pass in one of them if we only read the first?
| self.validators.iter().map(Validator::public_key), | ||
| ) | ||
| .unwrap(), | ||
| is_next_full_dkg: false, |
Contributor
There was a problem hiding this comment.
We could make this configurable to force a full DKG on start.
SuperFluffy
reviewed
Jan 2, 2026
SuperFluffy
reviewed
Jan 2, 2026
Zygimantass
pushed a commit
that referenced
this pull request
Jan 11, 2026
* on top of #1680 * uses the precompile to know when to execute a full/fresh dkg ceremony How it works * Outcome in the last block of `epoch_N-1` will specify if the next epoch will execute a full dkg ceremony * Outcome in the last block of `epoch_N` will have the new public * `epoch_N` will be using the new public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How it works
epoch_N-1will specify if the next epoch will execute a full dkg ceremonyepoch_Nwill have the new publicepoch_Nwill be using the new public