Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This PR updates various failing feeAMM tests introduces in `howy/add-feeamm-tests`.
This PR updates the feeAMM to return custom errors rather than strings to match the reference contract.
…o howy/add-feeamm-tests
0xKitsune
approved these changes
Dec 9, 2025
Contributor
0xKitsune
left a comment
There was a problem hiding this comment.
Lets plan to further increase fuzzing for functions like burn, mintWithValidatorToken, etc. in a subsequent PR.
Comment on lines
+131
to
+135
| try amm.mintWithValidatorToken(address(eurToken), address(validatorToken), 1e18, alice) { | ||
| revert CallShouldHaveReverted(); | ||
| } catch (bytes memory err) { | ||
| assertEq(err, abi.encodeWithSelector(IFeeAMM.InvalidCurrency.selector)); | ||
| } |
Contributor
There was a problem hiding this comment.
We should test both cases when the user token is USD but the validator token is not, as well as when the user token is non-USD but the validator token is.
unbalancedparentheses
pushed a commit
to unbalancedparentheses/tempo
that referenced
this pull request
Feb 23, 2026
This bumps fee amm test coverage of {lines, function, branches} from
~30-40% to 100%
No errors when run with foundry-tempo locally
---------
Co-authored-by: 0xKitsune <77890308+0xKitsune@users.noreply.github.com>
Co-authored-by: 0xKitsune <0xkitsune@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps fee amm test coverage of {lines, function, branches} from ~30-40% to 100%
No errors when run with foundry-tempo locally