Skip to content

feat: deprecate oval transaction builder#4882

Merged
md0x merged 4 commits intomasterfrom
pablo/deprecate-oval
Oct 6, 2025
Merged

feat: deprecate oval transaction builder#4882
md0x merged 4 commits intomasterfrom
pablo/deprecate-oval

Conversation

@md0x
Copy link
Copy Markdown
Contributor

@md0x md0x commented Oct 2, 2025

Changes proposed in this PR:

  • Deprecate Oval transaction builder

md0x added 3 commits October 2, 2025 16:00
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
@md0x md0x marked this pull request as ready for review October 2, 2025 19:25
Comment thread packages/scripts/src/admin-proposals/deprecate-oval-contracts/README.md Outdated
```sh
export TARGET_CONTRACTS="0xAddress1,0xAddress2,0xAddress3"
export SAFE_ADDRESS=<YOUR-SAFE-MULTISIG-ADDRESS>
export NODE_URL_1=http://localhost:8545
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this used in localhost network?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just for running against the local fork.

Reinis-FRP
Reinis-FRP previously approved these changes Oct 3, 2025
Copy link
Copy Markdown
Contributor

@Reinis-FRP Reinis-FRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, just minor nits in the readme

…README.md

Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
@md0x md0x merged commit 92ecb92 into master Oct 6, 2025
7 checks passed
@md0x md0x deleted the pablo/deprecate-oval branch October 6, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants