fix: update snapshot top level domain#4878
Merged
gsteenkamp89 merged 2 commits intomasterfrom Sep 26, 2025
Merged
Conversation
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes UMA-2946
Support Snapshot .box domain in rules parsing
Motivation
packages/monitor-v2/src/monitor-og/SnapshotVerification.tsto accept Snapshot’s.boxdomain (with optional subdomains likev1.), while retaining support for.org..box. The previous regex only matchedsnapshot.org, causing valid rules strings to be rejected.snapshot.organdsnapshot.box.Change
https://{optional-subdomain}.snapshot.(org|box)/#/...inparseRules.Example accepted rules string from Paraswap
I assert that this transaction proposal is valid according to the following rules: Proposals approved on Snapshot, as verified at https://v1.snapshot.box/#/paraswap-dao.eth, are valid as long as there is a minimum quorum of 90000000 and a minimum voting period of 120 hours and it does not appear that the Snapshot voting system is being exploited or is otherwise unavailable. The quorum and voting period are minimum requirements for a proposal to be valid. Quorum and voting period values set for a specific proposal in Snapshot should be used if they are more strict than the rules parameter. The explanation included with the on-chain proposal must be the unique IPFS identifier for the specific Snapshot proposal that was approved or a unique identifier for a proposal in an alternative voting system approved by DAO social consensus if Snapshot is being exploited or is otherwise unavailable.
Testing
/packages/monitor-v2/test/OptimisticGovernorMonitor.ts