fix: delay and timeout oo settlements#4868
Merged
Reinis-FRP merged 1 commit intomasterfrom Sep 16, 2025
Merged
Conversation
Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
md0x
reviewed
Sep 16, 2025
| logger.warn({ | ||
| at: "OOv3Bot", | ||
| message: "Execution deadline reached, skipping settlement", | ||
| remainingAssertions: setteableAssertions.length - i, |
Contributor
There was a problem hiding this comment.
Nit: For observability, we might want to add some more info to this log:
executionDeadline: params.executionDeadline,
now: Math.floor(Date.now() / 1000),
timeoutSec: Number(process.env.SETTLE_TIMEOUT) || 240,
Contributor
Author
There was a problem hiding this comment.
not sure if that adds much, since executionDeadline and now are going to be pretty close and also we have current timestamp in the logs
md0x
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Better handle processing of OO settlements when settleable requests are spiking.
Summary
Adds delay and timeout to OO settlement bots.
Details
SETTLE_DELAYenvironment (defaults to 5 minutes) allows other operators to settle OO requests/assertions reducing the risk of reverts.SETTLE_TIMEOUTenvironment (defaults to 4 minutes) allows avoiding parallel runs of multiple bot instances in serverless mode when the transaction submission takes longer than bot run cycle.Testing
Check a box to describe how you tested these changes and list the steps for reviewers to test.
Issue(s)
Fixes #XXXX