chore(serverless): Cleanup dependencies#4864
Merged
pxrl merged 1 commit intopxrl/serverlessWeb3from Sep 10, 2025
Merged
Conversation
Serverless had a few mis-specified dependencies, including some hard dependencies as dev dependencies, and some dev dependencies that weren't required at all.
Reinis-FRP
approved these changes
Sep 9, 2025
md0x
approved these changes
Sep 9, 2025
chrismaree
reviewed
Sep 9, 2025
| "@google-cloud/storage": "^6.4.2", | ||
| "chai": "^4.2.0", | ||
| "coveralls": "^3.1.0", | ||
| "@uma/logger": "^1.3.1", |
Member
There was a problem hiding this comment.
why a dev dependency? is this not strictly required for code to function?
Contributor
There was a problem hiding this comment.
It was a devDep, this change will move it to dependencies part of the package.json
devDep part: https://github.com/UMAprotocol/protocol/pull/4864/files#diff-0e36f050bb941938e7fbecd785a631bcc9367c7f2dc59076e7befe0dcc22c51eR16
Contributor
Author
There was a problem hiding this comment.
Yeah; the diff is displayed in a counter-intuitive way - it's actually a full dependency.
chrismaree
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serverless had a few mis-specified dependencies, including some hard dependencies as dev dependencies, and some dev dependencies that weren't required at all.