Skip to content

fix(optimistic-rewarder): [N07] addressed unused imports#3682

Merged
chrismaree merged 2 commits intomasterfrom
chrismaree/fix-unused-imports
Dec 13, 2021
Merged

fix(optimistic-rewarder): [N07] addressed unused imports#3682
chrismaree merged 2 commits intomasterfrom
chrismaree/fix-unused-imports

Conversation

@chrismaree
Copy link
Copy Markdown
Member

Motivation
OZ identified the following issue:

To improve readability of the code, consider removing the following unused imports:

  • The OptimisticRewarderBase contract imports the unused Constants contract
  • The OptimisticRewarderToken contract imports unused OptimisticRewarder contract
  • The OptimisticRewarderCreator contract imports unused ERC721 and Testable contracts
  • the OptimisticStaker contract imports usused OptimisticRewarder and
    OptimisticRewarderToken contracts

This PR addresses this by removing these imports.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

  • Ran end-to-end test, running the code as in production
  • New unit tests created
  • Existing tests adequate, no new tests required
  • All existing tests pass
  • Untested

Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
@chrismaree
Copy link
Copy Markdown
Member Author

Note that OZ commented that the The OptimisticRewarderBase contract imports the unused Constants contract which is redundant. this is not true. this contract requires this for accessing the OracleInterfaces library to pull things like OracleInterfaces.Store

@nicholaspai nicholaspai added the audit-fix-phase6 Fixes for Phase 6 (Cross-chain oracle, optimistic rewarder, decentralized proposer) label Dec 10, 2021
@nicholaspai nicholaspai changed the title fix(optimistic-rewarder): addressed unused imports fix(optimistic-rewarder): [N07] addressed unused imports Dec 10, 2021
@chrismaree chrismaree merged commit 29dcb76 into master Dec 13, 2021
@chrismaree chrismaree deleted the chrismaree/fix-unused-imports branch December 19, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-fix-phase6 Fixes for Phase 6 (Cross-chain oracle, optimistic rewarder, decentralized proposer)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants