Skip to content

fix(core-contracts): [N06] fix some typographical errors#3681

Merged
chrismaree merged 2 commits intomasterfrom
chrismaree/typographical-errors
Dec 13, 2021
Merged

fix(core-contracts): [N06] fix some typographical errors#3681
chrismaree merged 2 commits intomasterfrom
chrismaree/typographical-errors

Conversation

@chrismaree
Copy link
Copy Markdown
Member

Motivation

OZ identified a number of typographical errors:
In the Admin_ChildMessenger contract, impleenting should be implementing
In the OptimisticRewarderBase contract, timestap should be timestamp.
In the OptimisticRewarderBase contract, liveness liveness should be liveness.
In the GovernorSpoke contract, only called should be only be called.
In the Optimism_ChildMessenger contract:
onlyCrossDomainAccount should be onlyFromCrossDomainAccount.
addresses on the L1 should be addresses on the L2

This PR addresses these.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

  • Ran end-to-end test, running the code as in production
  • New unit tests created
  • Existing tests adequate, no new tests required
  • All existing tests pass
  • Untested

Signed-off-by: chrismaree <christopher.maree@gmail.com>
@nicholaspai nicholaspai added audit-fix-phase6 Fixes for Phase 6 (Cross-chain oracle, optimistic rewarder, decentralized proposer) cross-chain-oracle Contracts enabling cross-chain price resolution and governance labels Dec 10, 2021
@nicholaspai nicholaspai changed the title fix(core-contracts): fix some typographical errors fix(core-contracts): [N06] fix some typographical errors Dec 10, 2021
Signed-off-by: chrismaree <christopher.maree@gmail.com>
@chrismaree chrismaree merged commit 0593039 into master Dec 13, 2021
@chrismaree chrismaree deleted the chrismaree/typographical-errors branch December 13, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audit-fix-phase6 Fixes for Phase 6 (Cross-chain oracle, optimistic rewarder, decentralized proposer) cross-chain-oracle Contracts enabling cross-chain price resolution and governance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants