Merged
Conversation
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
ptare
approved these changes
Apr 16, 2020
Contributor
ptare
left a comment
There was a problem hiding this comment.
We don't need to do any of these, good to get rid of the TODOs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ptare I think their suggestion to remove TODOs is a reasonable one. Do you think any of these should be tracked separately or are they not worth it?
For exponentiation-by-squaring one, we could just remove the TODO and just mention an alternative implementation?
I'm not super concerned about making everything withdrawable.
I think we've decided (by default) that we don't want to parameterize the "majority" threshold.
Thoughts?