codeql/python/ql/test/query-tests/Functions/ModificationOfParameterWithDefault/test.py at e865a290dee644a12a9cd7bdd377ecc5a9b3682b · github/codeql · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
# Not OK
def simple(l = []):
    l.append(1)
    return l

# OK
def includes(l = []):
    x = [0]
    x.extend(l)
    x.extend([1])
    return x

def extends(l):
    l.extend([1])
    return l

# Not OK
def deferred(l = []):
    extends(l)
    return l

# Not OK
def nonempty(l = [5]):
    l.append(1)
    return l

# Not OK
def dict(d = {}):
    d['a'] = 1  # FN
    return d

# Not OK
def dict_nonempty(d = {'a': 1}):
    d['a'] = 2  # FN
    return d

# OK
def dict_nonempty_nochange(d = {'a': 1}):
    d['a'] = 1
    return d

def modifies(d):
    d['a'] = 1  # FN
    return d

# Not OK
def dict_deferred(d = {}):
    modifies(d)
    return d

# Not OK
def dict_method(d = {}):
    d.update({'a': 1})
    return d

# Not OK
def dict_method_nonempty(d = {'a': 1}):
    d.update({'a': 2})
    return d

# OK
def dict_method_nonempty_nochange(d = {'a': 1}):
    d.update({'a': 1})  # FP
    return d

def modifies_method(d):
    d.update({'a': 1})
    return d

# Not OK
def dict_deferred_method(d = {}):
    modifies_method(d)
    return d

# OK
def dict_includes(d = {}):
    x = {}
    x.update(d)
    x.update({'a': 1})
    return x