codeql/python/ql/test/query-tests/Security/CWE-022-PathInjection/test.py at 7afe3972d821de0c96d933a21642baa560597261 · github/codeql · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
import os.path

from flask import Flask, request

app = Flask(__name__)


def source():
    return request.args.get("path", "")


def normalize(x):
    return os.path.normpath(x)


@app.route("/path")
def simple():
    x = source()
    open(x)  # NOT OK


@app.route("/path")
def normalization():
    x = source()
    y = normalize(x)
    open(y)  # NOT OK


@app.route("/path")
def check():
    x = source()
    if x.startswith("subfolder/"):
        open(x)  # NOT OK


@app.route("/path")
def normalize_then_check():
    x = source()
    y = normalize(x)
    if y.startswith("subfolder/"):
        open(y)  # OK


@app.route("/path")
def check_then_normalize():
    x = source()
    if x.startswith("subfolder/"):
        y = normalize(x)
        open(y)  # NOT OK