BadCheckOdd.ql

/**
 * @name Bad parity check
 * @description Code that uses 'x % 2 == 1' or 'x % 2 > 0' to check whether a number is odd does not
 *              work for negative numbers.
 * @kind problem
 * @problem.severity warning
 * @precision low
 * @id java/incomplete-parity-check
 * @tags reliability
 *       correctness
 *       types
 */

import java
import semmle.code.java.Collections

predicate isDefinitelyPositive(Expr e) {
  isDefinitelyPositive(e) or
  e.(IntegerLiteral).getIntValue() >= 0 or
  e.(MethodCall).getMethod() instanceof CollectionSizeMethod or
  e.(MethodCall).getMethod() instanceof StringLengthMethod or
  e.(FieldAccess).getField() instanceof ArrayLengthField
}

from BinaryExpr t, RemExpr lhs, IntegerLiteral rhs, string parity
where
  t.getLeftOperand() = lhs and
  t.getRightOperand() = rhs and
  not isDefinitelyPositive(lhs.getLeftOperand()) and
  lhs.getRightOperand().(IntegerLiteral).getIntValue() = 2 and
  (
    t instanceof ValueOrReferenceEqualsExpr and rhs.getIntValue() = 1 and parity = "oddness"
    or
    t instanceof ValueOrReferenceNotEqualsExpr and rhs.getIntValue() = 1 and parity = "evenness"
    or
    t instanceof GTExpr and rhs.getIntValue() = 0 and parity = "oddness"
  )
select t, "Possibly invalid test for " + parity + ". This will fail for negative numbers."